Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply all clang-tidy fixes #5548

Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 9, 2024

Checklist

Required

Optional

Purpose of change

stacked on top of #5538, needs to be rebased once it's merged
apply all clang-tidy fixes so the codebase is cleaner

Describe the solution

$ parallel ./build-scripts/clang-tidy-wrapper.sh {} -fix ::: src/*.{cpp,h} tests/*.{cpp,h}; make astyle; ninja -C build -j 10 -k 0 cataclysm-bn-tiles cata_test-tiles CataAnalyzerPlugin; ./cata_test-tiles

Describe alternatives you've considered

disable unfixable warnings?

Testing

local tests passed.

Additional context

maybe run clang-tidy for edited files not affected files in future?

@github-actions github-actions bot added src changes related to source code. tests changes related to tests labels Oct 9, 2024
@scarf005 scarf005 force-pushed the refactor/c++20-clang-tidy-fixes branch from 48bfd3a to 73a227e Compare October 9, 2024 03:32
@scarf005 scarf005 marked this pull request as ready for review October 9, 2024 03:32
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I screm. Compiles and loads.

@scarf005 scarf005 merged commit 9405f05 into cataclysmbnteam:main Oct 9, 2024
12 of 14 checks passed
@scarf005 scarf005 deleted the refactor/c++20-clang-tidy-fixes branch October 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants